- May 23, 2017
-
-
Andras Timar authored
Change-Id: I8a7d5c95b57d87ccd04c317fa279142bc34b7068
-
Henry Castro authored
Change-Id: I12ede87cb8207257470720c130913e3ab7e967dd Reviewed-on: https://gerrit.libreoffice.org/37928 Reviewed-by:
Jan Holesovsky <kendy@collabora.com> Tested-by:
-
Henry Castro authored
Change-Id: I184a698fd63a0b3e83efb8c315ccca730d56112a Reviewed-on: https://gerrit.libreoffice.org/37927 Reviewed-by:
-
Pranav Kant authored
When WOPI's CheckFileInfo or GetFile responds with status code other than HTTP 200, show a message to the user indicating some problem in the storage. Currently, we open an empty document if storage doesn't return a document which surely is not correct. Mention the storage server address when asking user to contact the server administrator to be more friendly. Combination of following cherry-picks from master: (cherry picked from commit 2e9e6a75) (cherry picked from commit bcf958c5) (cherry picked from commit aed840ea) (cherry picked from commit 1ea87b62) Change-Id: I7e2455d3c4da8be2c476460b94812174c34fe529 Reviewed-on: https://gerrit.libreoffice.org/37903 Reviewed-by:
-
Pranav Kant authored
See inline comment Change-Id: I62456dd300eabaa156f9673fe13c190421c22ca0 (cherry picked from commit 62680fff) Reviewed-on: https://gerrit.libreoffice.org/37902 Reviewed-by:
-
Ashod Nakashian authored
When the server recylces, the client should transparently restore connection when the server is back on. This was broken because of the different times when moving in and out of focus for dimming/inactivity purposes. Here we track server recycling state separately, and skip the dimming/inactivity checks in that case. Reviewed-on: https://gerrit.libreoffice.org/37892 Reviewed-by:
Ashod Nakashian <ashnakash@gmail.com> Tested-by:
-
Ashod Nakashian authored
Fixes the case when the client reconnects on idle disconnection (because it never got the 'close: idle' message). Also, show informative message to users in this case instead of grey screen. Change-Id: Ia2e1f2ffefe6d35dd1552e7cc44e490aab86c600 Reviewed-on: https://gerrit.libreoffice.org/37891 Reviewed-by:
-
Pranav Kant authored
... in annotations. Emails, phone numbers, email address and what not. We are not sending the generated markup, eg: the html <a> tags back to LO core, only the representation in the UI is linkified. Autolinker license: MIT https://www.npmjs.com/package/autolinker (cherry picked from commit 3a10c480) and (cherry picked from commit 7486f44e) Change-Id: I0fa03cbd25d80121bb047691cf3969caee65a6ef Reviewed-on: https://gerrit.libreoffice.org/36923 Reviewed-by:
-
Ashod Nakashian authored
When a client connects with expired/invalid access_token, the document should remain active for other/existing clients, if any. However, if no clients exists (i.e. the first client has invalid access_token), then the document should be unloaded and cleaned up. Reviewed-on: https://gerrit.libreoffice.org/37916 Reviewed-by:
Michael Meeks <michael.meeks@collabora.com> Tested-by:
-
- May 22, 2017
-
-
Ashod Nakashian authored
Also, fix regression resulting in "This is embarrassing..." instead of "Unauthorized..." message. Change-Id: If6219bfbc445b186bb4064b3f20a0ccd2854d617 Reviewed-on: https://gerrit.libreoffice.org/37893 Reviewed-by:
-
- May 19, 2017
-
-
Ashod Nakashian authored
Change-Id: I7a16d82d8e9ebb120950fc1d0227ffdbe962d8e8 Reviewed-on: https://gerrit.libreoffice.org/36769 Reviewed-by:
-
- May 18, 2017
-
-
Andras Timar authored
Change-Id: I094dfec218f2c71c4cff1040c199ca448481d9cd
-
Andras Timar authored
Change-Id: I0655a0b80f7926471800691663894f89bd590174
-
Pranav Kant authored
Otherwise, WOPI implementations that use non-standard ports get CSP voilation errors in the browsers because Poco's URI::getHost() method strips the port number from the host. No harm in mentioning the port number always even if its a standard one, so always use Poco::URI::getPort() to append the port to the frame ancestor. Change-Id: I9e7a7021b38f717e14af3d389e30f24ecaf6d122 (cherry picked from commit 4ef373ce) Reviewed-on: https://gerrit.libreoffice.org/37786 Reviewed-by:
-
Andras Timar authored
Change-Id: Id087c7e380f86b6e43f7338bca4e7ecbd4fe26fc
-
Aditya Dewan authored
Change-Id: I799d2517496233e6ec04587c257eeada56769aca Reviewed-on: https://gerrit.libreoffice.org/37747 Reviewed-by:
pranavk <pranavk@collabora.co.uk> Tested-by:
-
Pranav Kant authored
Change-Id: Idb0e5454f5d795132c762e22c596710bfed75770 (cherry picked from commit 827d3f63) Reviewed-on: https://gerrit.libreoffice.org/37731 Reviewed-by:
-
- May 17, 2017
-
-
Jan Holesovsky authored
Otherwise the presesntation mode downloads them instead of showing. Change-Id: If2c9785aa5ef6bbb65e911b834c77ea83da281e7 Reviewed-on: https://gerrit.libreoffice.org/37715 Reviewed-by:
Marco Cecchetti <mrcekets@gmail.com> Tested-by:
-
Marco Cecchetti authored
Change-Id: I08eae6a1ba5c22f863f73a2625803f1b38e6e415 Reviewed-on: https://gerrit.libreoffice.org/37714 Reviewed-by:
-
Pranav Kant authored
Fallback from 1cb75cbc Change-Id: I47c8a470e5f4ab4d48859365d4435ae79c5fa82d (cherry picked from commit 1449d816) Reviewed-on: https://gerrit.libreoffice.org/37699 Reviewed-by:
-
- May 16, 2017
-
-
Andras Timar authored
Change-Id: I58a2142554ab5ab1972bccd34db6acbb809d8c38
-
Ashod Nakashian authored
Change-Id: Ib1d7ce1b880c71b0b2fd8262a92e7e965211653e Reviewed-on: https://gerrit.libreoffice.org/37375 Reviewed-by:
-
Pranav Kant authored
It is possible that backend sends comment for which there is no parent comment sent yet, as presently is the case as I am writing this. Warn nicely in this case. Change-Id: I2609dfdcdac69380b824d444ba8f64803996286c
-
Jan Holesovsky authored
Change-Id: I899503f9f1627cf07812f517923138a619195d7e
-
Michael Meeks authored
Change-Id: I5943cc0752f16d62d6eedf96351bb6f71a2311e6
-
Andras Timar authored
Change-Id: I18ebfff9eb4a87abd311086d6780514293ce6c7a
-
Ashod Nakashian authored
Timeouts to dimming the doc in the browser are now configurable from WSD and is relayed to loleflet as expected. Out of focus timeout is now 60 seconds. Change-Id: I8452e30976f6a81b0c3bb3ba5774daa244c1640c Reviewed-on: https://gerrit.libreoffice.org/37489 Reviewed-by:
-
Aditya Dewan authored
Change-Id: I6a0ee82e813e80344eaf6ddb7d46eebed98ca5bb Reviewed-on: https://gerrit.libreoffice.org/37674 Reviewed-by:
-
Pranav Kant authored
Document broker needs to know when the save request is sent and when the save finished. It uses these parameters to avoid shutting down document, in the document broker main polling loop, if save is already going on. But direct .uno:Save commands issued from loleaflet precludes document broker to keep track of it - in this case a .uno:Save command issued from loleaflet followed by shutting-down the wsd will prevent saving the document to storage, if document is huge enough and LO core takes a bit of time to save it. A save wrapper command, 'save', ensures that document broker is aware of all such save requests (_saveRequestTime member variable) and doesn't close the document until we completely save it (to storage and other cleanups). Change-Id: I5ec73d45adff23b2e7543e93dfd0624a5e5af46d (cherry picked from commit 1cb75cbc) Reviewed-on: https://gerrit.libreoffice.org/37643 Reviewed-by:
-
Ashod Nakashian authored
Show the user that authorization failed. Change-Id: Iad63c11ac2033eee80062ecd43dff76f776924c3 Reviewed-on: https://gerrit.libreoffice.org/37610 Reviewed-by:
-
Ashod Nakashian authored
Thread-affinity checks must be inhibited not just on Socket, but on the SocketPoll as well, before destroying DocumentBroker instances. Also, properly initialize the inhibit statics. Change-Id: I2ced1554d477f0c3faf09bda74034cbae99e4ce1 Reviewed-on: https://gerrit.libreoffice.org/37608 Reviewed-by:
-
Ashod Nakashian authored
When a document is idle (no activity from any views) for this timeout duration, the document is saved and unloaded to minimize resource consumption. Change-Id: If6f09136ae40c7e84180fc8c8adbf6db8396d292 Reviewed-on: https://gerrit.libreoffice.org/37374 Reviewed-by:
-
Ashod Nakashian authored
Two timeout are now configurable. idleTimeoutSecs, which controls when to dim because of user inactivity, even if the tab is in focus. outOfFocusTimeoutSecs, which controls when to dim when the tab loses focus. Currently they are set to 15 minutes and 30 seconds respectively by default. User_Idle event is now fired on dimming. Change-Id: I894f6df44825b6814872f1c4986fab8dcd4d6cef Reviewed-on: https://gerrit.libreoffice.org/37373 Reviewed-by:
-
Ashod Nakashian authored
Jail paths are now generate from a PRNG instead of using the PID of the kit process. The PRN is converted to base-64 and used as the directory name where a given kit is jailed. Change-Id: I8e4bc35d9ccdfdae0e542ab707c417cd29ad52f3 Reviewed-on: https://gerrit.libreoffice.org/37372 Reviewed-by:
-
Ashod Nakashian authored
Change-Id: Ibfcee83825bf8f48e635d93061bf4fd1306a95fc Reviewed-on: https://gerrit.libreoffice.org/37371 Reviewed-by:
-
Marco Cecchetti authored
Reworked handling of annotation layout. Now it behaves more like writer annotations. Now scrolling up annotations leads to scrolling the current slide too when it is required in order to show not visible annotations. Moreover the top visible annotation is now remembered for each slide, and when the top annotation is not the first one, a bit of the bottom of the previous annotation is showed so that the user gets aware that there are more annotations above. Change-Id: I3d087a8db35143a5e3abcd3e95e5e612d7638891 Reviewed-on: https://gerrit.libreoffice.org/37629 Reviewed-by:
-
Marco Cecchetti authored
Change-Id: Id0f52603af7eaa49979f68d222c9c94e79cf65b1 Reviewed-on: https://gerrit.libreoffice.org/37251 Reviewed-by:
-
Marco Cecchetti authored
Change-Id: Ib95870905d1bfc613ba454c7126501b3533e4ba5 Reviewed-on: https://gerrit.libreoffice.org/37083 Reviewed-by:
-
Jan Holesovsky authored
...but in combination with the appropriate session's access_token to always authenticate against the same instance of the WOPI host. Change-Id: Ic94dfa8fcb226a2d134272b22edc1f8f76c24e34 Reviewed-on: https://gerrit.libreoffice.org/37548 Reviewed-by:
-
Marco Cecchetti authored
Change-Id: Ic030724e392693847a195b5e53866b40ebad7435 Reviewed-on: https://gerrit.libreoffice.org/37359 Reviewed-by:
-
